std: reject interior NULs in Windows junction_point target path#594
Open
SebTardif wants to merge 1 commit into
Open
std: reject interior NULs in Windows junction_point target path#594SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Reparse substitute names are written as wide strings; embedded NULs would truncate the target. Reject early with InvalidInput. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject junction target paths (original and resolved absolute) that contain interior NUL before building the reparse substitute wide buffer.
Closes #591
Related: #542/#543 (chdir NUL), #548/#549 (junction buffer/rollback)
Origin
External-input audit: reparse path construction skipped early NUL validation.
Test plan