std: reject interior NULs in Windows env::join_paths segments#593
Open
SebTardif wants to merge 1 commit into
Open
std: reject interior NULs in Windows env::join_paths segments#593SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Joined PATH-style strings are later treated as C-style wide strings; embedded NULs would truncate segments. Reject them like other WinAPI string helpers. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject path segments containing interior wide NUL when joining for Windows
PATH-style env strings, in addition to existing\"/;checks.Closes #590
Origin
External-input audit: join_paths bypasses
to_u16s/ensure_no_nuls.Test plan