std: reject Windows File::truncate sizes that exceed i64::MAX#592
Open
SebTardif wants to merge 1 commit into
Open
std: reject Windows File::truncate sizes that exceed i64::MAX#592SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
size as i64 silently wraps huge values to negative EOF offsets. Match Unix ftruncate and return InvalidInput instead. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
try_into::<i64>()forFILE_END_OF_FILE_INFO::EndOfFileinstead ofsize as i64, returningInvalidInputon overflow (Unixftruncatealready does this).Closes #589
Related: #449 / #453 (prior attempt on older branch)
Origin
Windows FS implementation used a direct cast; Unix path validates via
try_into.Test plan
truncateerror contract