ty_utils: recurse through unsafe binder ops in const expr build#582
Open
SebTardif wants to merge 1 commit into
Open
ty_utils: recurse through unsafe binder ops in const expr build#582SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Wrap/unwrap unsafe binder THIR nodes do not change the constant value; build the const from the inner source expression instead of todo!. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recurse_buildtreated unsafe binder wrap/unwrap THIR nodes astodo!. Recurse into the innersourceexpression instead (transparent for const value trees).Closes #580
Related: #567, #570, #572
Origin
rust-lang@fc1a9186dcd
Test plan
sourcefor these expr kinds