std: implement Unix set_permissions_nofollow via fchmodat#571
Open
SebTardif wants to merge 1 commit into
Open
Conversation
Opening with O_NOFOLLOW fails with ELOOP when the path is a symlink, so the previous implementation could not chmod the link itself. Use fchmodat(AT_FDCWD, path, mode, AT_SYMLINK_NOFOLLOW) on platforms that support it; fall back to normal chmod on ESP-IDF/Horizon/Vita/VxWorks stubs. Closes #566 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace open+
O_NOFOLLOW+fchmodwithfchmodat(..., AT_SYMLINK_NOFOLLOW)so symlink paths can have permissions set on the link (or succeed as a no-op on filesystems that ignore symlink mode), instead of failing withELOOPon Linux/macOS.ESP-IDF / Horizon / Vita / VxWorks fall back to normal
chmodviaset_perm.Closes #566
Origin
set_permissions_nofollow(Tracking Issue for std::fs::set_permissions_nofollow rust-lang/rust#141607)library/std/src/sys/fs/mod.rsusedOpenOptions+O_NOFOLLOWTest plan
lchown/fstatatnofollow patterns inunix.rsset_permissions_nofollow(manual / CI)