std: implement Windows set_permissions_nofollow via reparse open#564
Open
SebTardif wants to merge 1 commit into
Open
std: implement Windows set_permissions_nofollow via reparse open#564SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Route path set_perm through handle-based SetFileInformationByHandle (follow reparse points with BACKUP_SEMANTICS), matching File::set_permissions. Add set_perm_nofollow with FILE_FLAG_OPEN_REPARSE_POINT so unstable fs::set_permissions_nofollow works on Windows for symlinks/junctions (WSL/interop), not only Unix. Closes #557 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs::set_permissions_nofollowon Windows by opening withFILE_WRITE_ATTRIBUTES | FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_OPEN_REPARSE_POINTand callingFile::set_permissions(handle-based attributes).set_permto the same handle path withoutOPEN_REPARSE_POINTso normalset_permissionsfollows links consistently withFile::set_permissions, instead of ambiguousSetFileAttributesWon the path.Closes #557
Origin
Pattern mirrors existing
set_times/set_times_nofollowinlibrary/std/src/sys/fs/windows.rs.Test plan
set_times_nofollow