ty: map CoroutineClosure and fold nested consts in ReverseMapper#561
Open
SebTardif wants to merge 1 commit into
Open
ty: map CoroutineClosure and fold nested consts in ReverseMapper#561SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
RPITIT/opaque reverse mapping handled Closure/Coroutine/CoroutineWitness but not CoroutineClosure, so async-closure captures in opaque concrete types skipped special fold_closure_args handling. Also super_fold non-param consts so nested params/regions inside unevaluated consts are remapped. Origin: ReverseMapper fold_ty in opaque_types.rs (pre-CoroutineClosure era gap) Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ty::CoroutineClosureinReverseMapper::fold_tyviafold_closure_args(same as Closure/Coroutine/CoroutineWitness).super_fold_withnon-param consts so nested params/regions inside unevaluated/expr consts are remapped.Closes #469
Test plan
./x.py test compiler/rustc_middle(optional)