Skip to content

Use std::move() to avoid copy #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wytsai7660 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use std::move() to avoid copy #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Item.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

// definition of Item
Item::Item() = default;
Item::Item(std::string name, const std::string tag, int price) : Object(name, tag) {
Item::Item(std::string name, const std::string tag, int price) : Object(std::move(name), tag) {
this->price = price;
}
void Item::setDescription(std::string _d) {
this->description = _d;
this->description = std::move(_d);
}
const std::string Item::getDescription() const {
return this->description;
Expand All @@ -15,7 +15,7 @@ const std::string Item::getDescription() const {
Equipment::Equipment() : Item(), health(0), attack(0), defense(0) {
}
Equipment::Equipment(std::string name, int price, int health, int attack, int defense)
: Item(name, "Equipment", price), health(health), attack(attack), defense(defense) {
: Item(std::move(name), "Equipment", price), health(health), attack(attack), defense(defense) {
}
int Equipment::getHealth() const {
return this->health;
Expand Down