Repository navigation
chore: upgrade Rust toolchain to 1.91.0 - #23
ScriptedAlchemy wants to merge 4 commits into
Conversation
- Updated rust-toolchain.toml to use Rust 1.91.0 (released Oct 30, 2025) - Updated all 4 rust-toolchain references in rust-ci.yml workflow from @1.90 to @1.91 This enables the latest Rust features and improvements.
|
|
Closing - Rust 1.91.0 upgrade causes build failures across multiple platforms. The tests pass but lint/build jobs fail, suggesting there may be new clippy lints or breaking changes in Rust 1.91.0 that need to be addressed. Will investigate the specific errors and create a new PR with the necessary code fixes to be compatible with Rust 1.91.0. |
- Replace manual Default impl with derived Default for PlanType enum - Replace manual Default impl with derived Default for ReadMode enum - Add #[default] attribute to mark default variants These changes fix new clippy warnings introduced in Rust 1.91.0 that were causing CI build failures due to -D warnings flag.
|
Reopening with fixes for clippy::derivable_impls warnings. The build failures were caused by new clippy lints in Rust 1.91.0. Fixed by:
CI should now pass. |
- Remove unused mut from build_client closure - Replace .unwrap_or_else() with explicit panic for better error handling - Simplify is_visible logic to satisfy needless_bool lint - Ensure compatibility with stricter clippy rules in Rust 1.91 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Upgrades the Rust toolchain from 1.90.0 to 1.91.0 (released October 30, 2025).
Changes
codex-rs/rust-toolchain.tomlfrom 1.90.0 to 1.91.0.github/workflows/rust-ci.ymlfrom@1.90to@1.91Benefits
Testing
CI will run across all platforms to verify compatibility.