Remove names dependency to avoid warnings#4
Open
naupaka wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nameshasn't been updated for a long time and the autoload now causes warnings that can be annoying on load, likeThis PR just removes the names dependency and manually namespaces the functions. So everything should continue to work identically as before but one less dependency and no warning.
I should mention everything was still working fine before this PR and also after, this is just to get rid of the dependency to avoid the warning. No hard feelings if you don't want to merge but I did this for myself so thought others might also appreciate.
Thanks for putting this together!