Adopt shared chrome from signage-kit 2026.7.2 (standardize footer badge) - #11
Merged
Merged
Conversation
Replace the "Powered by … screenly.io" footer lockup with the standardized fixed corner Screenly badge, and share the badge + font vendoring with the kit: - build.ts prepends the kit's styles/brand.css to main.css (brand.css is path-agnostic — only clamp/position, no url()). NOT the kit's fonts.css: this app uses RELATIVE asset paths (../fonts/…, ./images/…) for Pages-subpath portability, while fonts.css hard-codes /static/fonts/, so the app keeps its own relative @font-face and only shares the badge rules. - index.html: the <footer class="brand"> lockup (Powered by / logo / screenly.io) becomes the standard <a class="brand"> badge. main.css drops the local .brand/.brand-by/.brand-logo/.brand-url rules and the .brand entry in the position/z-index group and the small-screen @media. - sync-fonts.ts uses the kit's syncFonts(['fraunces','hanken-grotesk'],'assets/fonts'). - src/main.ts imports removeScreenlyBranding from the kit. - Drop the @fontsource deps (kit owns them, transitively); repoint kit to #2026.7.2. Verified: typecheck + lint + 35 tests clean; local screenshots show the fixed badge bottom-right and the 7-city board unchanged across the resolution matrix, in full + degraded mode, removed under a screenly-viewer UA. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the "Powered by … screenly.io" footer lockup with the standardized fixed corner Screenly badge and shares the badge + font vendoring with
@screenly-labs/signage-kit(2026.7.2).Changes
build.tsprepends the kit'sbrand.csstomain.css(path-agnostic). Not the kit'sfonts.css: this app uses relative asset paths (../fonts/,./images/) for Pages-subpath portability, whilefonts.csshard-codes/static/fonts/— so it keeps its own relative@font-faceand shares only the badge rules.index.html: the<footer class="brand">lockup → the standard<a class="brand">badge;main.cssdrops the local.brand*rules.sync-fonts.ts→syncFonts(['fraunces','hanken-grotesk'], 'assets/fonts');src/main.tsimportsremoveScreenlyBrandingfrom the kit;@fontsourcedeps dropped; kit repointed to#2026.7.2.Verification
typecheck+lint+ 35 tests clean. Local screenshots (static Pages app) confirm the fixed badge bottom-right and the 7-city board unchanged across 1920×1080 / 1080×1920 / 800×480 / 3840×2160, full + degraded, and removed under ascreenly-viewerUA. On merge, Pages deploys to world-clock.srly.io — I'll validate the live instance.🤖 Generated with Claude Code