Adopt shared chrome from signage-kit 2026.7.2 - #7
Merged
Conversation
Pull the footer badge, canonical @font-face set, fonts vendoring, and the .stage frame from @screenly-labs/signage-kit instead of restating them here: - @import the kit's fonts.css / brand.css / stage.css; drop the local @font-face blocks, the .brand rules, and the .stage rule (byte-identical to the canonical frame). - Drop the @fontsource deps (the kit owns them) and reduce sync-fonts.js to a one-line call to the kit's syncFonts(['bricolage-grotesque','hanken-grotesk']). - Import removeScreenlyBranding from the kit instead of the local copy. - Express the fluid root as --root-min/-gain/-max overrides (clamp lives in the preset); --font-sans (Hanken Grotesk) now comes from the preset, while --font-display stays overridden to Bricolage Grotesque, this app's display face. Keep the portrait 2x2 grid rule. Repoint the kit to #2026.7.2. Verified: build clean; badge in full+degraded across the resolution matrix (1080p/portrait/800x480/4K); removed under screenly-viewer UA; design unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the shared chrome from
@screenly-labs/signage-kit(tag 2026.7.2) so the timer app stops restating code the kit now owns. Pure DRY refactor — nothing visible changes.What moved into the kit
styles/fonts.css(canonical@font-faceset) and drop the local@font-faceblocks;sync-fonts.jsis now a one-linesyncFonts(['bricolage-grotesque','hanken-grotesk']). The@fontsource*deps are removed — the kit owns them.styles/brand.cssand delete the local.brand*rules (byte-identical, incl.z-index: 2).main.tsnow importsremoveScreenlyBrandingfrom@screenly-labs/signage-kit/brandinginstead of a local copy.styles/stage.cssand delete the local.stagerule (byte-identical to the canonical frame).--root-min/-gain/-max(16px / 1 / 54px); theclamp()lives in the preset.Kept per-app (design identity)
--font-display: 'Bricolage Grotesque'override (the preset default is Fraunces).@media (orientation: portrait)2×2 grid, and the count-up mint tint.--font-sansdeleted — it equalled the preset (Hanken Grotesk).Verification
typecheck+lint+test(28 pass) +buildall clean.screenly-viewerUA.masterbuild: layout, fonts, hierarchy, and badge position unchanged. Degraded mode fully legible.🤖 Generated with Claude Code