Adopt @screenly-labs/signage-kit for degraded mode - #5
Merged
Conversation
Replace the inlined degraded-mode plumbing (support floor, CSS down-level recipe, JS bundler, inline gate, replaceChildren shim, html.legacy kill-switch) with the shared package (github:Screenly-Labs/signage-kit#2026.7.0). Build output verified equivalent: 0 @layer, kill-switch present, 0 :lang(), gate injected, es2017. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the app’s “degraded mode” implementation (support floor, inline gate, CSS down-leveling recipe, JS bundling, and polyfills) from app-local copies to the shared @screenly-labs/signage-kit pipeline, aligning this repo with the fleet-wide rollout while keeping the shipped output equivalent.
Changes:
- Add
@screenly-labs/signage-kitand switch the build pipeline toinjectGate,processCss, andbundleJs. - Replace the inline degraded-mode gate in
index.htmlwith build-time injection. - Use the kit’s shared CSS preset + polyfills, removing the app-local polyfills shim and legacy CSS kill-switch block.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds @screenly-labs/signage-kit and removes the in-repo browserslist config block. |
| bun.lock | Locks @screenly-labs/signage-kit GitHub dependency resolution. |
| build.js | Replaces inlined CSS/JS build logic and gate injection with signage-kit helpers. |
| index.html | Removes the inline degraded-mode gate script in favor of build-time injection. |
| assets/static/styles/tailwind.css | Imports the kit preset and removes app-local degraded-mode kill-switch CSS. |
| assets/static/js/main.ts | Switches to the kit-provided polyfills side-effect import. |
| assets/static/js/polyfills.ts | Deletes the app-local replaceChildren shim (now provided by the kit). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide adoption of
@screenly-labs/signage-kit: this app now consumes the shared degraded-mode pipeline (support floor, CSS down-level recipe, JS bundler, inline gate, replaceChildren polyfill, and thehtml.legacykill-switch) instead of its own inlined copies.Purely mechanical — behaviour is unchanged. Build output verified equivalent:
@layerin built CSS: 0html.legacykill-switch present: yes (3):lang(in built CSS: 0es-check es2017 dist/static/js/main.js: passes<script defer>)typecheck, lint, and test all pass.
🤖 Generated with Claude Code