Raise CSS floor to Chrome 87 / Safari 14.1 (logical properties) - #4
Merged
Conversation
The apps use CSS logical properties (inset-inline-end, margin-inline-end, etc.) pervasively. At the previous Chrome 79 / Safari 11.1 floor those are below native support, so Lightning CSS lowered each single-sided logical property to physical right/left guarded by :not(:-webkit-any(:lang(...))) / :not(:is(:lang(...))) selectors. Chrome 79-86 reject that Level-4 :not() argument as invalid and drop the whole rule, so the physical position was silently lost -- e.g. the rss-reader QR fell to its default (left, overlapping the headline). inset-inline-end / margin-inline-end etc. are native at Chrome 87 / Safari 14.1, where Lightning CSS keeps them as-is (no fragile selectors). clamp/min/max, @layer flatten, svh/cqw fallbacks and color-mix lowering all remain in effect. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the degraded-mode work. Bug: on browsers below Chrome 87 / Safari 14.1, CSS logical properties (
inset-inline-end,margin-inline-end, …) were dropped — Lightning CSS lowered them to:not(:-webkit-any(:lang(…)))-guarded physical rules that those browsers reject as invalid. Most visible symptom: the rss-reader QR fell to the left, overlapping text.Fix: raise the
browserslistfloor tochrome >= 87,safari >= 14.1,firefox >= 78,edge >= 87— where these logical properties are native, so Lightning CSS keeps them as-is. All other down-leveling (clamp→max(min), @layer flatten, svh/cqw fallbacks, color-mix) remains in effect.Build-time only (browserslist is read at build); verified: 0 fragile
:lang()selectors in output, logical props native, typecheck/lint/tests/es-check pass.🤖 Generated with Claude Code