Declare target as a datetime widget in signage-app.json - #2
Merged
Conversation
The app store now renders a native date & time picker for manifest fields that ask for one. Switch target's x-widget from text to datetime (and add format: date-time for standards-compliance) so the picker appears instead of a bare ISO 8601 text box. The picker's value is the same ISO shape parseTarget already handles, so no player-side change is needed. Fixes #1 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timer's manifest declared
targetas a plain text box, so the app store rendered a bare text input where the user had to hand-type ISO 8601. The store-side renderer now supports native date/time pickers (x-widget: date|time|datetime, also inferred from JSON Schemaformat), so this is the one-field origin-manifest change needed for the picker to appear.Change
In
.well-known/signage-app.json, on thetargetproperty:x-widget:text→datetime"format": "date-time"for standards-complianceThe picker emits ISO 8601 (
YYYY-MM-DDTHH:MM:SS) — the same shapeparseTargetalready handles, so no player-side change is needed.Checks
bun test,bun run typecheck, andbun run lintall pass.Fixes #1
🤖 Generated with Claude Code