Promote to production: signage-kit 2026.7.2 chrome (rail badge) - #19
Merged
Conversation
Adopt the @screenly-labs/signage-kit shared chrome, matching the pattern already merged in the sibling Worker apps: - Fonts: rewrite sync-fonts.ts to the one-line kit wrapper, syncFonts(['bricolage-grotesque','hanken-grotesk','space-mono']); drop the local FONTS manifest and the @fontsource* deps. - build.ts: prepend the kit's styles/fonts.css + styles/brand.css to the app's raw main.css before processCss (a raw-CSS Worker can't resolve a bare @import), keeping includeDegraded. - main.css: delete the local @font-face blocks (now supplied by the kit's fonts.css). - package.json: repoint the kit to #2026.7.2, remove @fontsource* deps. Standardize the footer badge AND fix a real bug: the badge markup used class="rail__brand" (inline in the .rail masthead) while removeScreenlyBranding targeted .brand — so it NEVER hid on Screenly players. Standardize to the kit's fixed corner badge: rename the anchor's class rail__brand -> brand (href/rel/ aria/img unchanged), delete the local .rail__brand rules (the kit's prepended brand.css provides the fixed .brand), and replace the pasted-in local removeScreenlyBranding with the shared import from @screenly-labs/signage-kit/branding. The badge now actually hides on players. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adopt signage-kit 2026.7.2 shared chrome; fix badge-hide selector bug
The 2026.7.2 adoption moved the badge to the kit's fixed bottom-right corner badge, but rss-reader already renders a QR "scan to read" lockup in the bottom-right — the two overlapped (caught on stage). Keep the badge in the top rail instead: stop prepending the kit's brand.css, restore the local `.brand` rail rule (the former .rail__brand styling), and only share the @font-face set. The bug fix from the adoption stays: the element is `.brand` (not the old .rail__brand), so the shared removeScreenlyBranding() still hides it on Screenly players. Verified: lint + 68 tests clean; built main.css has the rail `.brand` (no position:fixed) and the 9 canonical @font-face. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…llision Fix: keep Screenly badge in the rail (avoid QR corner collision)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the 2026.7.2 adoption (shared @font-face + shared removeScreenlyBranding, badge kept in the rail) from master to production.
Validated on stage-rss.srly.io: the Screenly badge sits in the top rail (clear of the bottom-right QR lockup — the earlier fixed-corner collision is resolved), fonts load from the kit, the badge is removed under a screenly-viewer UA, and the story/fit layout is unchanged. The former
.rail__brand→.brandrename fixes the long-standing bug where the badge never hid on players.🤖 Generated with Claude Code