Adopt signage-kit 2026.7.2 shared chrome; fix badge-hide selector bug - #17
Merged
Conversation
Adopt the @screenly-labs/signage-kit shared chrome, matching the pattern already merged in the sibling Worker apps: - Fonts: rewrite sync-fonts.ts to the one-line kit wrapper, syncFonts(['bricolage-grotesque','hanken-grotesk','space-mono']); drop the local FONTS manifest and the @fontsource* deps. - build.ts: prepend the kit's styles/fonts.css + styles/brand.css to the app's raw main.css before processCss (a raw-CSS Worker can't resolve a bare @import), keeping includeDegraded. - main.css: delete the local @font-face blocks (now supplied by the kit's fonts.css). - package.json: repoint the kit to #2026.7.2, remove @fontsource* deps. Standardize the footer badge AND fix a real bug: the badge markup used class="rail__brand" (inline in the .rail masthead) while removeScreenlyBranding targeted .brand — so it NEVER hid on Screenly players. Standardize to the kit's fixed corner badge: rename the anchor's class rail__brand -> brand (href/rel/ aria/img unchanged), delete the local .rail__brand rules (the kit's prepended brand.css provides the fixed .brand), and replace the pasted-in local removeScreenlyBranding with the shared import from @screenly-labs/signage-kit/branding. The badge now actually hides on players. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts the
@screenly-labs/signage-kit2026.7.2 shared chrome in this raw-CSS Hono SSR Worker, matching the pattern already merged in the sibling Worker apps (moon).Shared chrome
sync-fonts.tsis now the one-line kit wrapper —syncFonts(['bricolage-grotesque','hanken-grotesk','space-mono'])(keepsexport const run). The local FONTS manifest and the@fontsource*deps are gone.styles/fonts.css+styles/brand.cssto the app's rawmain.cssbeforeprocessCss(a raw-CSS Worker can't resolve a bare@import), so the shared rules land first and the app's override where they overlap.includeDegraded: trueunchanged.@font-faceblocks deleted (now supplied by the kit'sfonts.css).#2026.7.2;@fontsource*deps removed.Badge standardization + bug fix
The footer badge markup used
class="rail__brand"(inline in the.railmasthead) whileremoveScreenlyBrandingtargeted.brand— so the badge never hid on Screenly players (a real bug). Fixed by standardizing to the kit's fixed corner badge:App.tsx: renamed the badge anchor's classrail__brand→brand(href/rel/aria/img unchanged).main.css: deleted the local.rail__brand/.rail__brand imgrules (theirborder-inline-startdivider went with them); the kit's prependedbrand.cssprovides the fixed.brand.main.ts: replaced the pasted-in localremoveScreenlyBrandingwithimport { removeScreenlyBranding } from '@screenly-labs/signage-kit/branding'. Now that the element is.brand, it actually hides on players.Verification
bun install,bun run typecheck,bun run lint,bun test(68 pass / 0 fail) — all green.main.css:@font-face× 9,.brand{× 1,position:fixedpresent,.rail__brand× 0. Built client JS:screenly-viewer× 1.main.cssrestored;main.jsis gitignored). Worker apps validate on stage after merge.🤖 Generated with Claude Code