expressions, grpc migration, a bit of cleanup - #16
Merged
Conversation
Signed-off-by: Devyash Saini <dysaini2004@gmail.com>
Signed-off-by: Devyash Saini <dysaini2004@gmail.com>
Signed-off-by: Devyash Saini <dysaini2004@gmail.com>
Signed-off-by: Devyash Saini <dysaini2004@gmail.com>
- Replace @connectrpc/connect with @grpc/grpc-js - Add grpc-tools and protoc-gen-ts for proto generation - Update gen script to generate both pb and grpc_pb files
Switch the SDK client and request flow from Connect to grpc-js, and build protobuf request messages with the backend-compatible google-protobuf runtime. Update the unit tests to target the new gRPC client seam instead of the removed Connect transport layer.
Add the grpc-tools output, google-protobuf runtime, and build/gen scripts needed to keep generated CommonJS protobuf files usable from the SDK's ESM dist output. Remove the old Connect-generated TypeScript artifacts from the published surface.
Signed-off-by: Devyash Saini <dysaini2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.