Skip to content

Fix main-thread ANR from TTS getVoices() binder call #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davecraig wants to merge 1 commit into
base: v1.0
Choose a base branch
from
Open

Fix main-thread ANR from TTS getVoices() binder call #961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions app/src/main/java/org/scottishtecharmy/soundscape/viewmodels/SettingsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import androidx.lifecycle.viewModelScope
import androidx.preference.PreferenceManager
import dagger.hilt.android.lifecycle.HiltViewModel
import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.MutableStateFlow
Expand All @@ -18,6 +19,7 @@ import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.collectLatest
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import org.scottishtecharmy.soundscape.MainActivity
import org.scottishtecharmy.soundscape.SoundscapeServiceConnection
import org.scottishtecharmy.soundscape.screens.onboarding.audiobeacons.getBeaconResourceId
Expand Down Expand Up @@ -90,9 +92,16 @@ class SettingsViewModel @Inject constructor(
if (initialized) {
// Only once the TextToSpeech engine is initialized can we populate the
// members of these lists.
val audioEngineTypes = audioEngine.getAvailableSpeechEngines()

val audioEngineVoiceTypes = audioEngine.getAvailableSpeechVoices()
// getAvailableSpeechEngines/getAvailableSpeechVoices end up making a
// synchronous Binder call into the system TTS service
// (ITextToSpeechService.getVoices), which can block for a long time on
// some OEM builds. Run them off the main thread to avoid ANRs.
val (audioEngineTypes, audioEngineVoiceTypes) = withContext(Dispatchers.IO) {
Pair(
audioEngine.getAvailableSpeechEngines(),
audioEngine.getAvailableSpeechVoices()
)
}
val voiceTypes = mutableListOf<String>()

// The list of voices will start of with those in the current locale
Expand Down
Loading