Skip to content

Complete fail-safe miner monitor state loading - #16799

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
nwinkelman2:fix/miner-monitor-state-shape
Sep 11, 2026
Merged

Complete fail-safe miner monitor state loading#16799
Scottcjn merged 1 commit into
Scottcjn:mainfrom
nwinkelman2:fix/miner-monitor-state-shape

Conversation

@nwinkelman2

Copy link
Copy Markdown
Contributor

Summary

Why

The original hardening caught JSON syntax errors and malformed individual rows, but structurally valid JSON such as [] or {"miners": []} still raised AttributeError outside the per-entry guard and aborted monitor startup.

Proof

  • targeted wrong-shape + save/load tests: 4/4 passed
  • complete miner monitor suite: 24/24 passed
  • Python compile and diff-integrity checks clean

Follow-up to the owner change request on #16791: #16791 (review)

@github-actions github-actions Bot added the needs-tier Maintainer must assign a review tier (contributor cannot self-label) label Sep 1, 2026
@Scottcjn
Scottcjn merged commit 3b9f211 into Scottcjn:main Sep 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-tier Maintainer must assign a review tier (contributor cannot self-label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants