Skip to content

legendary: Update 0.21.1, fix autoup., fix archits, fix license - #1830

Merged
Calinou merged 4 commits into
ScoopInstaller:masterfrom
SiriosDev:legenday-fix
Oct 19, 2026
Merged

Calinou merged 4 commits into
ScoopInstaller:masterfrom
SiriosDev:legenday-fix

Conversation

@SiriosDev

@SiriosDev SiriosDev commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Change in the release structure since version 0.21: there are now two releases, one for ARM64 and one for x64. In addition, Fixed minor issues such as the license type and description too, bringing them in line with the original repository.

@SiriosDev

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

legendary

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5994d92-ac55-4b63-bc8d-e0ec8c84334f
📥 Commits

Reviewing files that changed from the base of the PR and between 5c1851a and b20c08a.

📒 Files selected for processing: 1
  • bucket/legendary.json
🚧 Files skipped from review as they are similar to previous changes: 1
  • bucket/legendary.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Summary by CodeRabbit

  • Updates
    • Updated Legendary to version 0.21.1, with revised package description and usage guidance.
    • Windows downloads now include separate ARM64 and 64-bit builds. The legendary command uses the build matching the selected architecture, and automatic updates follow the same architecture-specific selection.

Walkthrough

The Legendary manifest now uses version 0.21.1. It defines separate Windows downloads, hashes, command mappings, and autoupdate URLs for arm64 and 64bit.

Changes

Legendary manifest

Layer / File(s) Summary
Version and architecture-specific downloads
bucket/legendary.json
The manifest updates package metadata and replaces the generic Windows download with separate arm64 and 64bit downloads, hashes, and command mappings. Autoupdate URLs now select the matching architecture-specific executable.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to b20c0

The architecture-specific install and autoupdate declarations are internally consistent. No merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the manifest update and the related architecture, autoupdate, and license fixes. It is concise and directly related to the changes.
Description check Passed The description provides a relevant summary and confirms that the contributing guide was read. It does not include the required Closes or Relates issue reference, but it is otherwise complete.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 43b81876-5bde-43b4-a1b1-f41cd0fe3dc1
📥 Commits

Reviewing files that changed from the base of the PR and between 7b9fdea and 5aec05c.

📒 Files selected for processing: 1
  • bucket/legendary.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Comment thread bucket/legendary.json Resolved
(Looking at the repo, it seemed to be GPLv3 only, But Coderabbit claims the opposite)
@Calinou Calinou added bug Something isn't working package update A package needs to be updated labels Oct 19, 2026
Comment thread bucket/legendary.json Resolved
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou
Calinou merged commit e1eb59b into ScoopInstaller:master Oct 19, 2026
2 checks passed
@SiriosDev
SiriosDev deleted the legenday-fix branch October 19, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package update A package needs to be updated review-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants