Skip to content

openttd-jgrpp: Add version 0.73.3 - #1822

Merged
Calinou merged 1 commit into
ScoopInstaller:masterfrom
h1635149164:master
Oct 5, 2026
Merged

Calinou merged 1 commit into
ScoopInstaller:masterfrom
h1635149164:master

Conversation

@h1635149164

Copy link
Copy Markdown
Contributor

Closes #1821

@h1635149164

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

openttd-jgrpp

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 244243bf-ed7c-4fdf-9b65-68836dafd7c2
📥 Commits

Reviewing files that changed from the base of the PR and between 296e95e and c106f68.

📒 Files selected for processing (1)
  • bucket/openttd-jgrpp.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Summary by CodeRabbit

  • New Features
    • Added support for installing OpenTTD JGR’s Patchpack version 0.73.3 on Windows, including 32-bit, 64-bit, and ARM64 systems.
    • The package includes the game executable and a Start menu shortcut, with updates available when new versions are released.

Walkthrough

Adds a Scoop manifest for OpenTTD JGR Patchpack version 0.73.3. It defines downloads and extraction settings for 32-bit, 64-bit, and ARM64 Windows, plus installation configuration and GitHub-based version detection and autoupdate templates.

Changes

OpenTTD JGR Patchpack

Layer / File(s) Summary
Package manifest
bucket/openttd-jgrpp.json
Adds version 0.73.3 metadata, architecture-specific download URLs, hashes and extraction directories, executable and shortcut settings, and GitHub-based version detection and autoupdate templates.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c106f

The manifest’s downloads and installation paths align with the inspected 0.73.3 release. No concrete merge-blocking issue was identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to c106f

The manifest uses HTTPS release URLs and fixed download hashes, without custom installation scripts, credentials, or privilege-changing declarations. No introduced security flaw was identified. Installation recovery and future-update integrity depend on the package manager and remain unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The new trust path reaches machines installing this package and subsequently executing its downloaded binary. A malicious accepted upstream artifact could act with the executable's launch authority; the manifest introduces no additional tenant, service, IAM, or secret authority.

Trust Boundaries and Controls

  • observed — The manifest crosses from GitHub-hosted release artifacts into local executable exposure. HTTPS URLs and fixed current-release hashes provide transport and integrity inputs for the package manager; they do not establish the downloaded program's internal security or future-release provenance.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the package and version being added.
Description check ✅ Passed The description links issue #1821 and confirms that the author read the contributing guide. The title provides a clear summary of the change.
Linked Issues check ✅ Passed Issue #1821 requests a Scoop package for OpenTTD JGR’s Patchpack release 0.73.3. The new manifest sets version 0.73.3 and provides release archive URLs and hashes for 32-bit, 64-bit, and ARM64. It def…
Out of Scope Changes check ✅ Passed The pull request adds only bucket/openttd-jgrpp.json. Its package metadata and install configuration directly support issue #1821. No unrelated changes appear in the whole-pull-request diff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Calinou Calinou added the new package A package should be added label Oct 5, 2026

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou
Calinou merged commit 20094ca into ScoopInstaller:master Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new package A package should be added review-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: openttd-jgrpp

2 participants