Skip to content

meshmc: Add version 10.0.0 - #1814

Open
YongDo-Hyun wants to merge 1 commit into
ScoopInstaller:masterfrom
YongDo-Hyun:add-meshmc-10.0.0
Open

YongDo-Hyun wants to merge 1 commit into
ScoopInstaller:masterfrom
YongDo-Hyun:add-meshmc-10.0.0

Conversation

@YongDo-Hyun

@YongDo-Hyun YongDo-Hyun commented Sep 29, 2026 •

Copy link
Copy Markdown

MeshMC packaging has been added, making MeshMC more accessible. It is licensed under Apache-2.0 and is a fork of MultiMC; its goal is to serve as a modular launcher. Plugins can be written using the MMCO (MeshMC Module Component Object) system.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Summary by CodeRabbit

  • New Features
    • Added MeshMC 10.0.0 for installation through Scoop on 64-bit and ARM64 Windows.
    • Added Windows file associations for .zip and .mrpack files, including an “Import into MeshMC” option.
    • Preserves MeshMC settings and application data across updates and saves them when the app is uninstalled.

Walkthrough

Adds a Scoop manifest for MeshMC 10.0.0 and registry files that register and remove its Windows file associations.

Changes

MeshMC package

Layer / File(s) Summary
Package lifecycle
bucket/meshmc.json
Adds 64-bit and ARM64 release downloads, persistence for application data, install and uninstall scripts, shortcuts, and GitHub version checking and autoupdate configuration.
Windows file associations
scripts/meshmc/install-associations.reg, scripts/meshmc/uninstall-associations.reg
Adds registry entries for MeshMC and .zip and .mrpack files, including an import command. The uninstall script removes the associated MeshMC registry entries.

Priority: ⬇️ Low

Merge Risk: 🟡 Moderate · up to 463e0

Installation downloads are correctly named, but file associations can fail to launch MeshMC or be removed from another installation. Fix the association commands and uninstall ownership check before merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 463e0

The change affects 2 systems.

Changed systems: scripts, bucket

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 2 changed files map to changed impact.
  • observed — bucket (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scripts/meshmc/install-associations.reg: Adds per-user Windows registry entries for MeshMC, including its executable icon and shell commands, application name and description, registered capabilities, and .zip and .mrpack open-with and file-association entries. The shell open command runs $EXEPATH; the application import command runs $EXEPATH -I with the selected file path.
  • observed — Modified behavior in scripts/meshmc/uninstall-associations.reg: Adds a Windows Registry uninstall script that deletes the meshmc.exe class and application keys, removes the MeshMC registered-application entry, and removes its .zip and .mrpack Open With list and ProgID entries.
  • observed — Modified behavior in bucket/meshmc.json: Adds the v10.0.0 package metadata, optional Visual C++ Redistributables suggestion, and architecture-specific release URLs with SHA-256 hashes for 64-bit and ARM64 Windows builds.
  • observed — Modified behavior in bucket/meshmc.json: Adds pre-install handling that disables migration for global installs with multiple enabled local accounts, restores or initializes accounts.json, metacache, and meshmc.cfg, and removes meshmc-updater.exe.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description. It does not include the required issue reference or the Contributing Guide confirmation. Add a description that summarizes the MeshMC 10.0.0 manifest and registry association changes. Include a valid "Closes #XXXX" or "Relates to #XXXX" reference and complete the Contributing Guide checklist, if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the MeshMC manifest addition and the version included in the pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f2f3e762-b2ad-4c7b-bdfe-b6b2dca4045d

📥 Commits

Reviewing files that changed from the base of the PR and between 69e672b and 8cd79d5.

📒 Files selected for processing (3)
  • bucket/meshmc.json
  • scripts/meshmc/install-associations.reg
  • scripts/meshmc/uninstall-associations.reg

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Comment thread bucket/meshmc.json Resolved
Comment thread bucket/meshmc.json Resolved
Comment thread scripts/meshmc/install-associations.reg Resolved
Comment thread scripts/meshmc/install-associations.reg Resolved
Signed-off-by: Mehmet Samet Duman <yongdohyun@projecttick.org>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6c173533-0d88-4a9c-b6b4-513e4a31bff3

📥 Commits

Reviewing files that changed from the base of the PR and between 8cd79d5 and 463e0b4.

📒 Files selected for processing (1)
  • bucket/meshmc.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Comment thread bucket/meshmc.json Resolved
Comment thread bucket/meshmc.json Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant