Use SciMLTesting v1.2 (folder-based run_tests) - #36
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Replace the hand-written GROUP dispatch in test/runtests.jl with the SciMLTesting v1.2 folder-discovery harness (`using SciMLTesting; run_tests()`). - Core = top-level test/*.jl (core_tests.jl, alloc_tests.jl) in the main test env — same files the old dispatcher ran for Core/All. - QA = test/qa/. Move qa.jl from the top level into test/qa/ so that folder-discovery's Core glob (all top-level *.jl) does not erroneously run it. - Add SciMLTesting to root [extras]/[targets].test/[compat] and add SafeTestsets + SciMLTesting to the QA sub-env Project.toml (the harness wraps the QA file in a @safetestset, so SafeTestsets must be resolvable in that env). Drop Pkg from the test deps (the v1.2 harness owns all Pkg operations; no test/*.jl uses Pkg). - test/test_groups.toml unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
marked this pull request as ready for review
June 14, 2026 23:54
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 20, 2026
The folder-based SciMLTesting harness (PR #36) runs test/alloc_tests.jl as part of the Core group across the full version x OS matrix, including the `pre` channel (currently 1.13.0-rc1). The original alloc test was deliberately scoped to GROUP=nopre on a single x86_64-linux runner, because AllocCheck builds on GPUCompiler/LLVM compiler internals that are unstable on Julia prereleases. On 1.13.0-rc1 / aarch64-macOS, `@check_allocs` reports a spurious 1 allocation (0 dynamic dispatches) for the surrogate call, failing CI. The same test passes on lts (1.10), 1 (1.12), and even 1.13.0-rc1 on x86_64-linux. Verified locally: file is a clean no-op on 1.13.0-rc1, and the AllocCheck tests still run and pass (3/3, 1/1) on 1.10 and 1.12. Gate the AllocCheck testsets on `isempty(VERSION.prerelease)`, restoring the original nopre intent while keeping full coverage on released Julia. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2 folder-discovery model.
test/runtests.jlis now just:Group → folder mapping (behavior-preserving — the exact set of files run under each
GROUPis unchanged):test/*.jl(core_tests.jl,alloc_tests.jl), each in its own isolated@safetestset, in the main test env.test/qa/(existing per-groupProject.tomlsub-env).qa.jlis moved from the top level intotest/qa/so folder-discovery's Core glob (all top-level*.jl) does not erroneously run it as a Core file.Dependency edits:
SciMLTestingto the root[extras]/[targets].test/[compat].SafeTestsets+SciMLTestingtotest/qa/Project.toml(the harness wraps the QA file in a@safetestset, soSafeTestsetsmust be resolvable in that sub-env).Pkgfrom the test deps + compat (the v1.2 harness owns allPkgoperations; notest/*.jlusesPkg).test/test_groups.tomlis unchanged.Ignore until reviewed by @ChrisRackauckas.