Audit public reexports and inherited module docs#27
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 20, 2026
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
I validated this PR's current head ( It improves the result substantially, reducing the rendered-public-API failure from 300 names to nine, but the harness still fails: These are inherited values/constants or enum values. Reproduction setup:
The analogous |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 21, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
This PR handles public reexports in two separate ways:
@docsblock. Re-exported functions and types still require a local rendered API entry.run_qagains an opt-incheck_reexports = trueaudit. It remains off by default to avoid a breaking fleet-wide change. Intentional facade API is listed withreexports_allow.public_reexportshelper detects imported functions, types, modules, constants, macros, and operators, plus aliases whose values expose module ownership.Julia cannot recover source-binding provenance after locally assigning scalar/enum values, callable objects, or constructed Union types; direct imports are fully covered.
Local verification:
Pkg.test()passed, 318/318.Pkg.test()passed, 333/333.git diff --checkpassed.