Folder discovery: skip CI-matrix-only group alias sections#22
Merged
ChrisRackauckas merged 1 commit intoJul 12, 2026
Merged
Conversation
A test_groups.toml section with a `group` key is a matrix-only alias: it runs the named group's body under a different matrix cell (e.g. a 32-bit lane `["Core 32-bit"] group = "Core"` that CI runs with `arch = "x86"`) and has no test folder of its own. Previously folder-discovery mode treated every declared section as a group needing a `test/<name>/` folder, so such a section broke `GROUP=All` / `Everything` / a bare `Pkg.test()` with "folder is missing". Skip alias sections under All/Everything (the target group already runs), and when one is selected by its own name run the target group instead of demanding a folder. Document the `group` key in `read_test_groups` and add a folder-mode test. Minor bump 2.1.0 -> 2.2.0 (new recognized test_groups.toml key). Verified: with `["Core 32-bit"] group = "Core"` declared, GROUP=All runs Core+Light without throwing, and GROUP="Core 32-bit" runs the Core body. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EcQkauMQ4KSytnTpJpXUZu
ChrisRackauckas
marked this pull request as ready for review
July 12, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables 32-bit (and any alternate-arch) CI lanes declared through test_groups.toml without breaking GROUP=All / bare Pkg.test().
Problem
The SciML/.github matrix generator supports a
groupalias key (SciML/.github#113, v1.24.0): a section like["Core 32-bit"] group="Core" arch="x86"runs Core's tests in a 32-bit CI cell. But folder-discovery mode treats every declared section as a group needing atest/<name>/folder, soGROUP=All/Everything/ barePkg.test()throw 'folder is missing'. (This is why FindFirstFunctions.jl's Downgrade job, which runs GROUP=All, failed when it declared a 32-bit lane.)Fix
Recognize a
groupkey as a matrix-only alias (runs the named group's body, no folder of its own): All/Everything skip alias sections; selecting one by name runs the target group. Documented the key inread_test_groups; added a folder-mode test. Minor bump 2.1.0 -> 2.2.0.Verification
Full Pkg.test() passes. With
["Core 32-bit"] group="Core": GROUP=All runs Core+Light with no throw (previously ArgumentError); GROUP="Core 32-bit" runs the Core body.Companion: SciML/.github#114 (i386 libs before setup-julia), SciML/.github#113 (arch axis, merged v1.24.0). Consumer FindFirstFunctions.jl re-adds its Core 32-bit lane once released.
Please ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code