Make Core5 parameter_handling u0 Float32-homogeneous (fixes LuxLib mixed-precision warning) - #1691
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Avoid LuxLib mixed-precision matmul fallback warnings that fail @test_nowarn when Float64 zeros/ones u0 meet Float32 ComponentArray parameters. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.28-64d2043 Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/issue-backlog/ibd/SciMLSensitivity.jl/jobs/1609-cursor/log.txt on amdci2.julia.csail.mit.edu
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Summary
test/Core5/parameter_handling.jlbuilt NonlinearProblem / ODEProblem states with defaultFloat64zeros/oneswhile Lux parameters in theComponentArrayareFloat32. That mismatch triggers LuxLib's mixed-precisionmatmul_cpu_fallback!warning, which fails@test_nowarn. This change makes the three state constructionsFloat32so they match the existingx = ones(Float32, 2, 3)and Lux params. No production code changed;@test_nowarnis intentionally left strict.Closes #1609
Verification
Scratch env (Pkg.develop of this repo + Lux, ComponentArrays, NonlinearSolve, OrdinaryDiffEq, Zygote, Test), Julia 1.12.7:
Before (unmodified master contents of the test file)
After (this PR)
(exit code 0; both
@test_nowarnpaths and nested Zygote gradients completed)Also:
Runic --checkandtyposon the touched file both exit 0.Not verified
GROUP=Core5/Pkg.test()suite (only this file was run, to keep load down on a busy machine).Reviewer push-back
@test_nowarnand non-nothinggradients (existing assertions kept as-is).Risk assessment
src/changesparameter_handling.jlwith the mixed-precision warning present then absentPlease ignore this draft until reviewed by @ChrisRackauckas.
Harness: Cursor Agent CLI 2026.09.28-64d2043; model: auto; transcript: /home/crackauc/sandbox/goals/issue-backlog/ibd/SciMLSensitivity.jl/jobs/1609-cursor/log.txt on amdci2.julia.csail.mit.edu