Fix stable problem-trait documentation links - #1485
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Fix stable problem-trait documentation links#1485ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 2, 2026 21:14
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
problem_typedocstring links from the undeployed stableProblem_TraitspageProblems/#Problem-Traitssection insteadRoot cause
PR #1468 introduced absolute links to
https://docs.sciml.ai/SciMLBase/stable/interfaces/Problem_Traits/. The page exists in current source and in the GitHub Pagesdevtree, but the deployedstabledocumentation is still v3.22 and does not contain that route. The CloudFront/S3 endpoint therefore returns HTTP 403, causing every documentation build since #1468 to fail strict link checking.The replacement target exists in both v3.22 and current sources and returns HTTP 200. It retains a portable absolute link for docstrings rendered by downstream documentation sites.
Investigation trail
curland an untouched checkout of upstream masterb6e131a37.makedocsterminate with[:linkcheck]on the same URL.30035957346passed; PR Portable absolute URLs for docstring @refs that break DiffEqDocs (#879) #1468 run30072174284was the first to fail with the exact URL.6807f7fd5introduced all affected links.Validation
timeout 3600 julia +1.12 --color=yes --project=docs docs/make.jl— passed, including strict linkcheck and HTML renderingtimeout 3600 env GROUP=Core julia +1.12 --color=yes --project=. -e 'using Pkg; Pkg.test()'— passed (SciMLBase tests passed)--check— passedgit diff --check— passedcurlof the replacement URL — HTTP 200The existing strict documentation build is the regression test for the broken external link. No link is ignored or downgraded to a warning.