Update permutation_init doctests for Julia 1.13 randperm - #538
Merged
ChrisRackauckas merged 1 commit intoSep 13, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Julia 1.13 changed `randperm`'s implementation, so the fixed-seed permutation matrices shown in the `permutation_init` docstring examples no longer match. Regenerate the four literal outputs on Julia 1.13. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.10.21 Agent-Model: SWE-2 Max Agent-Session: /home/crackauc/.local/share/devin/cli/summaries/history_4c9fddb81d834736.md
Member
Author
|
Status note: the Core/Extensions/Interface group failures on julia 1 and lts are also red on master (https://github.com/SciML/ReservoirComputing.jl/actions/runs/34675972677) and are unrelated to this doctest-only change, which targets the GPU Documentation job. |
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 13, 2026
- Drop x86 CI lane (BFloat16s LLVM soft-promote on i686). (#535) - Add AirspeedVelocity benchmarking CI (#537) - Update permutation_init doctests for Julia 1.13 randperm (#538) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
GPU Documentationjob on master fails fourpermutation_initdoctests insrc/inits/inits_reservoir.jl. Julia 1.13 changedrandperm's implementation (randperm(Xoshiro(1234), 5)gives[3,2,4,5,1]on 1.12 vs[4,3,1,2,5]on 1.13), so the fixed-seed permutation matrices in the docstring no longer match.This regenerates the four literal outputs on Julia 1.13. The evaluated values were confirmed byte-for-byte against the CI failure output (run 34675972399) and reproduced locally.
Verification
Each doctest's new expected output matches what
permutation_initevaluates to on Julia 1.13.0, e.g.permutation_init(5, 5)now shows the column-3/4/2/1/5 permutation CI produced. TheMersenneTwister(123)example needs no update — it only asserts properties (sizeand sorted nonzero values), not the permutation order.Note: the
Testsfailure on the same master run is a separate resolved-upstream issue (OrdinaryDiffEqDefault2.6.2 now requiresOrdinaryDiffEqCore≥ 4.17.1, which provides_is_identity_massmatrix); it will pass on the next CI run and is not addressed here.Generated with Devin CLI 3000.10.21 (model: SWE-2 Max), session: /home/crackauc/.local/share/devin/cli/summaries/history_4c9fddb81d834736.md