Move initializers to WeightInitializers.jl - #213
Closed
MartinuzziFrancesco wants to merge 4 commits into
Closed
MartinuzziFrancesco wants to merge 4 commits into
MartinuzziFrancesco wants to merge 4 commits into
Conversation
Collaborator
Author
|
Closing this as the current initializer set is highly field-specific to reservoir computing (delay lines, cycle reservoirs, chaotic-map/chebyshev/logistic encodings, LSM connectivity). Moving all of that into a generic, framework-agnostic package like WeightInitializers.jl wouldn't provide any benefit I can immediately see. The initializers in ReservoirComputing.jl will continue to use WeightInitializers.jl as guidelines for implementation and testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will need the PR on WeightInitializers.jl to be merged first