QA: run_qa v1.6 form + ExplicitImports - #168
Merged
ChrisRackauckas merged 1 commit intoJun 25, 2026
Merged
Conversation
Convert the hand-rolled test/qa/qa.jl Aqua calls to SciMLTesting 1.6.0's
run_qa, with ExplicitImports enabled (explicit_imports = true). The eight
individual Aqua.test_* calls collapse to Aqua.test_all via run_qa; the
`recursive = false` ambiguities tweak is preserved through
aqua_kwargs = (; ambiguities = (; recursive = false)). No JET (the prior QA
did not run JET).
ExplicitImports findings (all FIXED in src, 0 ignore / 0 broken):
- no_stale_explicit_imports: dropped unused LinearAlgebra imports
SymTridiagonal, eigen, pinv (kept I, dot, issymmetric, which are used).
- no_implicit_imports: made the `using SpecialFunctions, SparseArrays,
Distributions` implicit imports explicit:
using SpecialFunctions: beta, gamma
using SparseArrays: SparseVector, spzeros
using Distributions: Beta, Continuous, Distribution, Gamma, Logistic,
Normal, Uniform, Univariate
- The other four EI checks already passed.
Deps: test/qa/Project.toml SciMLTesting compat -> "1.6"; drop SafeTestsets
(not used by qa.jl; the harness provides @safetestset at the runtests level).
Aqua kept (the ambiguities sub-check spawns a child process needing Aqua as a
direct dep). Root Project.toml: drop Aqua (now exclusively a qa sub-env dep
since QA runs in its own folder env), bump SciMLTesting compat to "1.6".
Verified locally against released SciMLTesting 1.6.0 (Julia 1.12.5): QA group
17/17 Pass, 0 Fail/Error/Broken (11 Aqua sub-checks + 6 ExplicitImports
checks).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
marked this pull request as ready for review
June 25, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Converts the hand-rolled
test/qa/qa.jl(eight individualAqua.test_*calls) to SciMLTesting 1.6.0'srun_qa, with ExplicitImports enabled (explicit_imports = true).qa.jl
Aqua.test_*calls collapse intoAqua.test_allviarun_qa.test_ambiguities(PolyChaos, recursive = false)tweak is preserved viaaqua_kwargs = (; ambiguities = (; recursive = false)).ExplicitImports findings — all FIXED in src (0 ignore, 0 broken)
no_stale_explicit_imports: dropped unusedLinearAlgebraimportsSymTridiagonal,eigen,pinv(verified unused insrc/; not exported, not method-extension placeholders). KeptI,dot,issymmetric(used).no_implicit_imports: made the implicitusing SpecialFunctions, SparseArrays, Distributionsexplicit:all_explicit_imports_via_owners,all_qualified_accesses_via_owners,all_qualified_accesses_are_public,all_explicit_imports_are_public: already passing.Deps
test/qa/Project.toml:SciMLTestingcompat ->"1.6"; droppedSafeTestsets(unused byqa.jl; the harness provides@safetestsetat theruntestslevel);Aquakept (the ambiguities sub-check spawns a child process that needsAquaas a direct dep).ExplicitImportsnot added (transitive via SciMLTesting).Project.toml: droppedAquafrom[compat]/[extras]/[targets].test(now exclusively a QA sub-env dep since QA runs in its own folder env); bumpedSciMLTestingcompat to"1.6".Verification (local, released SciMLTesting 1.6.0, Julia 1.12.5)
QA group: 17/17 Pass, 0 Fail/Error/Broken (11 Aqua sub-checks + 6 ExplicitImports checks). All six EI checks confirmed passing individually.
🤖 Generated with Claude Code