Extrapolation: drop stale BaseThreads/Sequential imports#3945
Merged
ChrisRackauckas merged 1 commit intoJul 20, 2026
Merged
Conversation
Neither is referenced anywhere in the package; only PolyesterThreads is actually used (algorithms.jl threading dispatch). Fixes the no_stale_explicit_imports QA failure independently of SciML#3940's separate all_explicit_imports_are_public fix for the same package.
singhharsh1708
force-pushed
the
fix-extrapolation-stale-imports
branch
from
July 18, 2026 07:33
22b5f14 to
a2f1a0d
Compare
ChrisRackauckas
added a commit
that referenced
this pull request
Jul 21, 2026
Releases unreleased changes on master across four sublibraries: - OrdinaryDiffEqCore 4.7.1 -> 4.8.0 (minor: restores isdiscretecache public API (#3907); also recompute non-lazy interpolation stages after a truncated step (#3964)) - OrdinaryDiffEqBDF 2.3.1 -> 2.3.2 (precompile a mass matrix DAE in the workload (#3966)) - OrdinaryDiffEqExtrapolation 2.3.0 -> 2.3.1 (drop stale BaseThreads/Sequential imports (#3945)) - OrdinaryDiffEqRosenbrock 2.4.1 -> 2.4.2 (SIMD-fuse RosenbrockCache stage loops; document public HybridExplicitImplicitRK (#3938)) Claude-Session: https://claude.ai/code/session_01SFmcAmLrGPrGtzwP333mX8 Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
OrdinaryDiffEqExtrapolation'sno_stale_explicit_importsQA check fails on master:Neither name is referenced anywhere in the package;
grepacrosssrc/finds each only on the import line itself.PolyesterThreads, imported on the same line, is genuinely used (algorithms.jl's threading dispatch) and is kept.Fix
Drop the two unused names from the
import OrdinaryDiffEqCore: ...list.Scope note
This package's QA lane has a second, unrelated failure (
all_explicit_imports_are_public, 6 non-publicOrdinaryDiffEqDifferentiationnames) already covered by #3940. That's a separate root cause (a public-API declaration regression from #3832) with its own fix in flight — not duplicated here.Verification
ExplicitImports.check_no_stale_explicit_imports(OrdinaryDiffEqExtrapolation)returnsnothing(passes) against this branch, checked directly against a local dev checkout (not the registry) to avoid version-pinning ambiguity. Package loads and precompiles cleanly. Runic clean.AI Disclosure
Claude assisted with this work.