Stabilize OptimizationBBO multi-objective tests#1277
Merged
ChrisRackauckas merged 1 commit intoJul 20, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Scratchpad for commit
|
ChrisRackauckas
marked this pull request as ready for review
July 20, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until reviewed by @ChrisRackauckas.
Summary
Investigation
The current downgrade workflow reached the OptimizationBBO tests and exposed a pre-existing stochastic failure. The trigger commit changed only the root
Optimcompat; its diff contains no OptimizationBBO, OptimizationBase, or downgrade-workflow changes.History analysis identifies
a8299ec5b(2024-08-18) as the commit that added the exact multi-objective assertions after the pre-existingmaxtime = 5solve. That timed solve advances global RNG state by a load-dependent amount. BlackBoxOptim constructs its randomized initial population before applying its run-time seed, so the later asserted objectives varied across clean processes and CI machines. A 100-seed reproduction produced an assertion failure at seed 668073.The fix seeds immediately before each solve, covering population construction as well as the subsequent optimizer run. It does not change production behavior, test tolerances, expected values, or test counts.
Local verification
25 passed / 25 totalboth times, with byte-identical Rosenbrock/Ackley objectives.25 passed / 25 total.25 passed / 25 total.git diff --check: clean.Process notes