Approve intentional NonlinearSolve umbrella reexports#1102
Approve intentional NonlinearSolve umbrella reexports#1102ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
Investigation note for commit
|
|
CI verification: the dedicated |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
Follow-up commit Evidence:
|
|
CI verification for |
|
Superseded: master already carries the equivalent |
Ignore this PR until reviewed by @ChrisRackauckas.
Summary
@reexportowner modules, so unrelated accidental reexports still fail QARoot cause
SciMLTesting 2.4.0 enabled
check_reexportsby default. NonlinearSolve and NonlinearSolveQuasiNewton already computed partial allowlists for external APIs in rendered-doc QA, but did not pass complete facade allowlists to the new check. Clean master therefore reported 393 root reexports and 211 QuasiNewton reexports as unapproved.On the same clean master and Julia 1.12.6, pinning SciMLTesting 2.3.0 passes 18/18 root QA checks; SciMLTesting 2.4.0 fails only the new reexport check. The default-on change is SciMLTesting commit
2881f4c15fb715f0934009a800d42765751587b1.Local verification
GROUP=QA julia +1.12 --project=. -e "using Pkg; Pkg.test()"with SciMLTesting 2.4.0: 19/19 passedGROUP=QA julia +1.12 --project=. -e "using Pkg; Pkg.test()": 20/20 passedgit diff --check: passed