Skip to content

Guard Adjoint tests from SciMLBase 3.32 resolver break#1017

Closed
ChrisRackauckas-Claude wants to merge 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:agent/adjoint-scimlbase-compat-guard
Closed

Guard Adjoint tests from SciMLBase 3.32 resolver break#1017
ChrisRackauckas-Claude wants to merge 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:agent/adjoint-scimlbase-compat-guard

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

This PR should be ignored until reviewed by @ChrisRackauckas.

Summary

The Adjoint test environment can currently resolve SciMLBase v3.32.0 with registered SciMLSensitivity v7.113.0 and FunctionProperties v0.1.7. That combination fails while precompiling SciMLBaseFunctionPropertiesExt because SciMLBase 3.32 calls FunctionProperties predicates that are only present in FunctionProperties 1.1.

This temporarily bounds the Adjoint test environment to SciMLBase = "2.154, 3.0 - 3.31", matching the resolver combination that was passing before SciMLBase 3.32 entered the environment. The underlying package-side compat fix is tracked separately in SciMLBase PR #1424.

Validation

  • timeout 3600 env NONLINEARSOLVE_TEST_GROUP=Adjoint ~/.juliaup/bin/julia +1 --project=. -e 'using Pkg; Pkg.test(; julia_args=["--check-bounds=auto"])'\n- timeout 3600 ~/.juliaup/bin/julia +1 -e 'using Runic; exit(Runic.main(["--check", "."]))'\n- git diff --check\n\nThe local Adjoint test run resolved SciMLBase v3.31.0, SciMLSensitivity v7.113.0, and FunctionProperties v0.1.7; SciMLBaseFunctionPropertiesExt precompiled successfully and the Adjoint tests passed.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Scratchpad update: root NonlinearSolve CI for this branch is green, including the Adjoint lanes this PR targets. The current downstream failures in OrdinaryDiffEq Interface / Regression are consistent with SciML/.github#110: the reusable downstream.yml@v1 workflow accepts a group input but currently does not export it as GROUP, so downstream jobs run unintended/default suites. The workflow fix is green in SciML/.github#110; callers pinned to @v1 need the floating tag/reference advanced after that lands.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

CI update: SciML/.github v1 now points at v1.21.0 / 12371ec79ba3, which includes the downstream GROUP export fix. I pushed empty commit 979835996 to trigger fresh CI on this PR because direct rerun failed with HTTP 403 for this token. Fresh downstream run started as https://github.com/SciML/NonlinearSolve.jl/actions/runs/29000398529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants