Migrate to SciMLTesting v1.2 (off ParallelTestRunner)#144
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Merged
Conversation
Replace the ParallelTestRunner-based test/runtests.jl (find_tests +
runtests + a hand-written GROUP-delete dispatch) with SciMLTesting v1.2
explicit-args run_tests. SciML parallelizes tests at the CI-matrix level
per GROUP (grouped-tests.yml@v1), so the in-process worker parallelism of
ParallelTestRunner is redundant and a recurring source of new-Julia-release
breakage.
Behavior-preserving:
- Core: the functional suite (models/{fno,deeponet,nomad}_tests,
layers/{spectral_conv,spectral_kernel}_tests).
- QA: Aqua/ExplicitImports + doctests, moved into test/qa/ with their own
test/qa/Project.toml sub-env (Aqua, Documenter, ExplicitImports live there
now, out of the root test env).
- GPU: the self-hosted CUDA cell still runs the full functional + QA suite,
expressed as the umbrella GPU => ["Core", "QA"]. The Reactant tests pick up
CUDA through reactant_device() as before.
- All (bare local Pkg.test()): Core then QA, as before.
test_groups.toml is unchanged; its Core/QA/GPU keys still drive the CI matrix.
Each test file runs inside its own @safetestset (file-level isolation replaces
the old per-file worker isolation). The XLA/CUDA memory env wrapping is kept,
pinned to one job per process since each GROUP cell is now its own CI process.
GROUP dispatch (Core/QA/GPU/All) verified against SciMLTesting v1.2 locally.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
ParallelTestRunner-basedtest/runtests.jlwithSciMLTestingv1.2 explicit-argsrun_tests.Why
SciML parallelizes tests at the CI-matrix level per
GROUP(this repo already usesgrouped-tests.yml@v1and atest/test_groups.toml).ParallelTestRunner's in-process worker parallelism is therefore redundant, and that family of runners is a recurring source of breakage on new Julia releases. This swaps the runner for the sharedSciMLTestingharness while keeping the test matrix and exact group semantics.What changed
test/runtests.jl:find_tests/runtests+ the hand-writtenGROUP-delete dispatch ->using SciMLTesting; run_tests(; core, qa, umbrellas). The XLA/CUDA memorywithenvwrapping is preserved (pinned to one job per process, since eachGROUPcell is now its own CI process).test/qa/(qa_tests.jl,doctests.jl) with a newtest/qa/Project.tomlsub-env.Aqua,Documenter, andExplicitImportsnow live in that sub-env and are removed from the root test env.test/Project.toml: removedParallelTestRunner; addedSciMLTestingandSafeTestsets.test/test_groups.toml: unchanged — itsCore/QA/GPUkeys still drive the CI matrix.Behavior-preserving group mapping
models/{fno,deeponet,nomad}_tests,layers/{spectral_conv,spectral_kernel}_tests).test/qasub-env.umbrellas = Dict("GPU" => ["Core", "QA"]). The Reactant tests pick up CUDA throughreactant_device()as before.Pkg.test()) -> Core then QA.Each test file now runs inside its own
@safetestset(file-level isolation replaces the old per-file worker isolation). The test bodies and assertions are unchanged.Verification
Project.toml/test_groups.tomlparses; allruntests.jl/test.jlfiles parse with no error nodes; Runic-clean.GROUPdispatch (Core/QA/GPU/All) was exercised againstSciMLTestingv1.2 locally with recording thunks and routes exactly as the oldruntests.jldid (Core->Core,QA->QA-in-subenv,GPU->Core+QA,All->Core+QA). The full ML suite (Reactant/Enzyme/CUDA + a custom Reactant git rev) is left to per-PR CI to validate.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code