refactor: Convert SemilinearODEFunction to use SciMLFunctionOptions#4828
Merged
Conversation
…olkit)
Applies the ModelingToolkitBase.SciMLFunctionOptions pattern to
SemilinearODEFunction, the one *Function constructor that lives in the
top-level ModelingToolkit package rather than ModelingToolkitBase. Its
kwargs... wrapper now assembles a SciMLFunctionOptions and delegates to
a
new public SemilinearODEFunction{iip,specialize}(sys,
opts::SciMLFunctionOptions;
kwargs...) method that does the real work without splatting arbitrary
keywords, matching every other constructor in the family.
Like the rest of the family, the struct-accepting method branches
directly
on the struct's own `expression` type parameter (`if E`) instead of a
separate `expression = Val{E}` local, and builds its
ObservedFunctionCache
by forwarding the nested GeneratedFunctionOptions directly rather than
re-listing its fields as separate keywords.
Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the ModelingToolkitBase.SciMLFunctionOptions pattern to SemilinearODEFunction, the one *Function constructor that lives in the top-level ModelingToolkit package rather than ModelingToolkitBase. Its kwargs... wrapper now assembles a SciMLFunctionOptions and delegates to a new public SemilinearODEFunction{iip,specialize}(sys, opts::SciMLFunctionOptions; kwargs...) method that does the real work without splatting arbitrary keywords, matching every other constructor in the family.
Like the rest of the family, the struct-accepting method branches directly on the struct's own
expressiontype parameter (if E) instead of a separateexpression = Val{E}local, and builds its ObservedFunctionCache by forwarding the nested GeneratedFunctionOptions directly rather than re-listing its fields as separate keywords.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.