Fix Runic format-check on master (ModelingToolkitBase)#4824
Merged
ChrisRackauckas merged 1 commit intoJul 23, 2026
Merged
Conversation
Runic 1.7 format-check fails on two ModelingToolkitBase files:
- discretedomain.jl: space after comma in Union{Nothing, Real}
- optimal_control_interface.jl: explicit return on ODEInputFunction
Matches CI Runic diffs exactly; verified with Runic.format_string.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 23, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
Master
format-check(Runic) is red on the latest push (11b86e7/ ModelingToolkitBase v1.56.1 bump):Two files fail Runic 1.7:
lib/ModelingToolkitBase/src/discretedomain.jl—Union{Nothing,Real}→Union{Nothing, Real}lib/ModelingToolkitBase/src/systems/optimal_control_interface.jl— explicitreturnon finalODEInputFunction{...}(Verification
Runic.format_string(...; filemode=true)reports both files OK after the changeNo semantic / API changes.
Co-Authored-By: Chris Rackauckas accounts@chrisrackauckas.com