Skip to content

test: ControlSystemsMTK now uses inline_linear_sccs = true by default#4820

Merged
AayushSabharwal merged 1 commit into
masterfrom
as/downstream-fixes
Jul 24, 2026
Merged

test: ControlSystemsMTK now uses inline_linear_sccs = true by default#4820
AayushSabharwal merged 1 commit into
masterfrom
as/downstream-fixes

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 460f368... master / 460f368...
ODEProblem 5.48 ± 0.19 ms 5.36 ± 0.24 ms 1.02 ± 0.058
init 0.0685 ± 0.021 ms 0.0539 ± 0.02 ms 1.27 ± 0.62
large_parameter_init/ODEProblem 25.2 ± 2.4 ms 25.1 ± 2.4 ms 1 ± 0.13
large_parameter_init/init 0.0917 ± 0.03 ms 0.0918 ± 0.028 ms 0.998 ± 0.45
mtkcompile 9.43 ± 0.47 ms 9.06 ± 0.37 ms 1.04 ± 0.067
sparse_analytical_jacobian/ODEProblem 27.2 ± 1.4 ms 26 ± 1.4 ms 1.05 ± 0.079
sparse_analytical_jacobian/f_iip 0.071 ± 0.001 μs 0.068 ± 0.001 μs 1.04 ± 0.021
sparse_analytical_jacobian/f_oop 0.375 ± 0.012 ms 0.377 ± 0.012 ms 0.995 ± 0.044
time_to_load 6.08 ± 0.088 s 6.02 ± 0.044 s 1.01 ± 0.016
Memory benchmarks
master 460f368... master / 460f368...
ODEProblem 0.0376 M allocs: 1.92 MB 0.0376 M allocs: 1.94 MB 0.992
init 0.428 k allocs: 0.0723 MB 0.428 k allocs: 0.0723 MB 1
large_parameter_init/ODEProblem 0.325 M allocs: 11.4 MB 0.325 M allocs: 11.4 MB 1
large_parameter_init/init 0.616 k allocs: 0.175 MB 0.616 k allocs: 0.175 MB 1
mtkcompile 0.0618 M allocs: 3.43 MB 0.0618 M allocs: 3.43 MB 1
sparse_analytical_jacobian/ODEProblem 0.193 M allocs: 7.93 MB 0.193 M allocs: 7.93 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 460f368... master / 460f368...
ODEProblem 5.07 ± 0.15 ms 5.1 ± 0.19 ms 0.995 ± 0.047
init 0.0571 ± 0.018 ms 0.0559 ± 0.019 ms 1.02 ± 0.49
large_parameter_init/ODEProblem 25 ± 5 ms 25.6 ± 5.3 ms 0.974 ± 0.28
large_parameter_init/init 0.0787 ± 0.037 ms 0.0824 ± 0.035 ms 0.956 ± 0.61
mtkcompile 8.31 ± 0.66 ms 8.61 ± 0.63 ms 0.965 ± 0.1
sparse_analytical_jacobian/ODEProblem 22.8 ± 2.9 ms 24.5 ± 3.5 ms 0.929 ± 0.18
sparse_analytical_jacobian/f_iip 0.09 ± 0.001 μs 0.08 ± 0.001 μs 1.12 ± 0.019
sparse_analytical_jacobian/f_oop 0.121 ± 0.013 ms 0.122 ± 0.013 ms 0.994 ± 0.15
time_to_load 5.7 ± 0.035 s 5.75 ± 0.01 s 0.992 ± 0.0063
Memory benchmarks
master 460f368... master / 460f368...
ODEProblem 0.0375 M allocs: 1.7 MB 0.0375 M allocs: 1.72 MB 0.991
init 0.426 k allocs: 0.0545 MB 0.426 k allocs: 0.0545 MB 1
large_parameter_init/ODEProblem 0.351 M allocs: 12.6 MB 0.351 M allocs: 12.6 MB 1
large_parameter_init/init 0.809 k allocs: 0.154 MB 0.809 k allocs: 0.154 MB 1
mtkcompile 0.0598 M allocs: 2.75 MB 0.0598 M allocs: 2.76 MB 0.994
sparse_analytical_jacobian/ODEProblem 0.186 M allocs: 6.89 MB 0.186 M allocs: 6.89 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.149 k allocs: 11.1 kB 0.145 k allocs: 11 kB 1.02

@AayushSabharwal
AayushSabharwal merged commit 0a980e8 into master Jul 24, 2026
59 of 68 checks passed
@AayushSabharwal
AayushSabharwal deleted the as/downstream-fixes branch July 24, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant