Lock SciCompDSL downgrade tests to in-repo sources#4808
Merged
ChrisRackauckas merged 1 commit intoJul 22, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Terminal CI classification for exact head
All nine failures are therefore accounted for by exact-parent behavior, runner infrastructure, or the two prerequisites already declared in this PR. No additional change to the focused SciCompDSL floor/path-source patch is indicated by this run. |
ChrisRackauckas
marked this pull request as ready for review
July 22, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without
Pkg.PRESERVE_ALL, the test setup can silently replace the graph chosen by the downgrade job. In the control run, it upgraded ModelingToolkitBase 1.0 to 1.54, OrdinaryDiffEqTsit5 1.0 to 2.1, and SciMLBase 2.146 to 3.36 before running the tests.With the source-aware graph, the resolved package floors remain unchanged across the controlled
Pkg.developstep. Path entries and Julia-runtime stdlib/JLL patch metadata may be normalized, but the tested package graph is no longer silently upgraded.Prerequisites
This is one focused repository-side part of the downgrade fix and depends on:
28fff4537e765348717821087862dc537353e6a3) for recursive path-source-aware resolution4d16630091d8a7c4397f0fe3653d88beaad7b15c) for promoting test targets before downgrade resolutionThe shared workflow also needs to save the original Project.toml before the downgrade action mutates it; otherwise its current restore step preserves the action-mutated project rather than the checkout copy. That workflow follow-up is intentionally not included here.
Local validation
Using Julia 1.10.11, pinned General
ebea3c922b48a58438335288df661a3b4b2f85ae, and the exact prerequisite heads above:Pkg.develop([MTKBasePkgSpec, MTKPkgSpec]; preserve = Pkg.PRESERVE_ALL)— passed, with key package versions preservedjulia-runtest@v1invocation withALLOW_RERESOLVE=false— passed:git diff --check— passedNo test was skipped, silenced, or loosened.