Skip to content

Fix QA/Core CI: drop unmatched sublibrary [sources] from test/qa/Project.toml#201

Merged
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:fix-qa-env-sources
Jun 17, 2026
Merged

Fix QA/Core CI: drop unmatched sublibrary [sources] from test/qa/Project.toml#201
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:fix-qa-env-sources

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Problem

Master CI is red. The tests / Core (julia 1), tests / Core (julia pre), and tests / QA (julia 1) jobs all fail at environment activation:

ERROR: LoadError: Sources for `JumpProblemLibrary` not listed in `deps` or `extras` section
at ".../test/qa/Project.toml".

test/qa/Project.toml listed every sublibrary (BVProblemLibrary, DAEProblemLibrary, DDEProblemLibrary, JumpProblemLibrary, NonlinearProblemLibrary, ODEProblemLibrary, SDEProblemLibrary) under [sources], but only DiffEqProblemLibrary is declared in [deps]. On the current CI Julia (1.12.6), Pkg.activate validates the project and rejects any [sources] key without a matching [deps]/[extras] entry.

This breaks both the QA group and the Core group, since Core reaches the same activate_qa_env path through the Core => QA umbrella in runtests.jl.

Fix

The qa env only needs DiffEqProblemLibrary (the QA test, qa/qa.jl, just runs ExplicitImports checks on DiffEqProblemLibrary). The root package's own [sources] transitively resolve the sublibraries, so the per-sublibrary [sources] entries in the qa env were spurious. Keep only DiffEqProblemLibrary = {path = "../.."}.

Local verification (Julia 1.12.6, same as CI's "julia 1")

Before (reproduces the CI failure):

ACTIVATE_ERROR: Sources for `JumpProblemLibrary` not listed in `deps` or `extras` section ...

After (this branch):

ACTIVATE_OK
INSTANTIATE_OK
Test Summary:   | Pass  Total   Time
ExplicitImports |    2      2  15.8s
QA_GROUP_OK

This does not address the separate downgrade-sublibraries / test (lib/BVProblemLibrary) failure (UndefVarError: BVPFunction not defined at the downgrade compat floor), which is a pre-existing downgrade compat-floor issue tracked separately.

Please ignore until reviewed by @ChrisRackauckas.

ChrisRackauckas and others added 2 commits June 15, 2026 10:18
…toml

The test/qa environment listed every sublibrary (BVProblemLibrary,
DAEProblemLibrary, ..., SDEProblemLibrary) under [sources] without a
matching [deps]/[extras] entry. On Julia 1.12, Pkg.activate validates the
project and errors:

    Sources for `JumpProblemLibrary` not listed in `deps` or `extras`
    section at ".../test/qa/Project.toml".

This broke both the QA group and the Core group (Core reaches the same
activate_qa_env path via the Core => QA umbrella in runtests.jl).

The qa env only needs DiffEqProblemLibrary, which transitively resolves
its own sublibrary [sources]; the per-sublibrary entries were spurious.
Keep only the DiffEqProblemLibrary path source.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Spell Check job flagged two genuine false-positives:
- "Comput" in "Math. Comput." (Mathematics of Computation journal abbreviation)
  in lib/DDEProblemLibrary/src/ddetst.jl
- "Collum" in the surname "McCollum" (paper author)
  in lib/JumpProblemLibrary/src/JumpProblemLibrary.jl

Add both to default.extend-words so typos accepts them.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 17, 2026 10:41
@ChrisRackauckas ChrisRackauckas merged commit be637c6 into SciML:master Jun 17, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants