Fix QA/Core CI: drop unmatched sublibrary [sources] from test/qa/Project.toml#201
Merged
ChrisRackauckas merged 2 commits intoJun 17, 2026
Merged
Conversation
…toml
The test/qa environment listed every sublibrary (BVProblemLibrary,
DAEProblemLibrary, ..., SDEProblemLibrary) under [sources] without a
matching [deps]/[extras] entry. On Julia 1.12, Pkg.activate validates the
project and errors:
Sources for `JumpProblemLibrary` not listed in `deps` or `extras`
section at ".../test/qa/Project.toml".
This broke both the QA group and the Core group (Core reaches the same
activate_qa_env path via the Core => QA umbrella in runtests.jl).
The qa env only needs DiffEqProblemLibrary, which transitively resolves
its own sublibrary [sources]; the per-sublibrary entries were spurious.
Keep only the DiffEqProblemLibrary path source.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Spell Check job flagged two genuine false-positives: - "Comput" in "Math. Comput." (Mathematics of Computation journal abbreviation) in lib/DDEProblemLibrary/src/ddetst.jl - "Collum" in the surname "McCollum" (paper author) in lib/JumpProblemLibrary/src/JumpProblemLibrary.jl Add both to default.extend-words so typos accepts them. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master CI is red. The
tests / Core (julia 1),tests / Core (julia pre), andtests / QA (julia 1)jobs all fail at environment activation:test/qa/Project.tomllisted every sublibrary (BVProblemLibrary,DAEProblemLibrary,DDEProblemLibrary,JumpProblemLibrary,NonlinearProblemLibrary,ODEProblemLibrary,SDEProblemLibrary) under[sources], but onlyDiffEqProblemLibraryis declared in[deps]. On the current CI Julia (1.12.6),Pkg.activatevalidates the project and rejects any[sources]key without a matching[deps]/[extras]entry.This breaks both the QA group and the Core group, since
Corereaches the sameactivate_qa_envpath through theCore => QAumbrella inruntests.jl.Fix
The qa env only needs
DiffEqProblemLibrary(the QA test,qa/qa.jl, just runsExplicitImportschecks onDiffEqProblemLibrary). The root package's own[sources]transitively resolve the sublibraries, so the per-sublibrary[sources]entries in the qa env were spurious. Keep onlyDiffEqProblemLibrary = {path = "../.."}.Local verification (Julia 1.12.6, same as CI's "julia 1")
Before (reproduces the CI failure):
After (this branch):
This does not address the separate
downgrade-sublibraries / test (lib/BVProblemLibrary)failure (UndefVarError: BVPFunction not definedat the downgrade compat floor), which is a pre-existing downgrade compat-floor issue tracked separately.Please ignore until reviewed by @ChrisRackauckas.