Require strict SciMLTesting 2.4 QA - #146
Merged
ChrisRackauckas merged 1 commit intoJul 27, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 27, 2026 04:44
ChrisRackauckas
added a commit
that referenced
this pull request
Aug 5, 2026
#146 added SciMLBase, SymbolicIndexingInterface, SymbolicUtils and Symbolics as direct dependencies. Downgrade CI only pins direct dependencies, so those four went from "resolved to newest compatible" to "pinned at their declared floor", which selected Symbolics 7.18.1. At that version the diode model in the ANTLR suite produces a system whose W matrix is singular, so every Rosenbrock step falls through to LinearSolve's QR fallback and the integrator never terminates. The run is not slow, it does not converge: one hour of wall time produced 11.3 billion allocations while still inside solve!. Raising only the Symbolics floor fixes it. The solver stack is not involved: GROUP=Core passes with SciMLBase still at 3.1.0, OrdinaryDiffEqCore at 4.3.0 and LinearSolve at 3.87.0. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Removes all BaseModelica-specific Aqua and ExplicitImports QA waivers and runs plain
run_qa(BaseModelica)under SciMLTesting 2.4. Direct imports now use the declaring public APIs rather than ModelingToolkit/Symbolics reexports or PythonCall builtins.Also enables doctests and export coverage in Documenter, documents the public API at its definition sites, and ensures it is rendered on the API page.
Local verification:
Pkg.test()passed: 75 Julia-parser, 138 ANTLR-parser, and 25 error-message tests.checkdocs = :exports, and HTML rendering passed.git diff --checkpassed.No
[sources]entries or path dependencies were added.