Skip to content

fix(project): accept legacy version 3 project files #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
doogie99 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Draft

fix(project): accept legacy version 3 project files #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/ProjectOpeningContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ ProjectOpeningContext::~ProjectOpeningContext() {
void ProjectOpeningContext::proceed() {
if (!m_reader.success()) {
deleteLater();
if (!m_reader.getVersion().isNull() && (m_reader.getVersion().toInt() != PROJECT_VERSION)) {
const int version = m_reader.getVersion().toInt();
if (!m_reader.getVersion().isNull() && (version < 3 || version > PROJECT_VERSION)) {
QMessageBox::warning(m_parent, tr("Error"),
tr("The project file is not compatible with the current application version."));
return;
Expand Down
5 changes: 4 additions & 1 deletion src/core/ProjectReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ ProjectReader::ProjectReader(const QDomDocument& doc, const QString& projectFile
QDomElement projectEl(m_doc.documentElement());

m_version = projectEl.attribute("version");
if (m_version.isNull() || (m_version.toInt() != PROJECT_VERSION)) {
// Version 3 projects (4lex4-era through v1.1.x) are readable as is:
// attributes added since then all have fallbacks in the readers.
const int version = m_version.toInt();
if (m_version.isNull() || version < 3 || version > PROJECT_VERSION) {
return;
}

Expand Down