feat: add support for scalingo-26 by EtienneM · Pull Request #597 · Scalingo/php-buildpack

EtienneM · 2026-05-22T13:38:54Z

No description provided.

notion-workspace · 2026-05-22T13:38:58Z

Frzk

I have a few concerns regarding tidy and gmp.
And another detail related to amqp (we may have to package this extension).
Else LGTM, nice work <3

Frzk · 2026-05-27T09:51:32Z


+if [ "$STACK" = "scalingo-26" ] && [ "${zend_api_version}" -ge "${PHP_MODULE_API_VERSIONS['8.5']}" ]; then
+	echo "Apply the patch to fix a call to IS_INTERNED"
+	patch -p1 < /buildpack/support/ext/mongodb-is-interned.patch


praise: I love how you handled this <3

Frzk · 2026-05-27T09:52:47Z

 mkdir -p /app/vendor/gmp
 pushd "gmp-${gmp_version}" > /dev/null
-./configure --prefix=/app/vendor/gmp
+# We need the `CC` flag since gcc v15 (used in scalingo-26).


question: shall we have a conditional here for stacks < scalingo-26? (or does it work?)

Even though the default changed in gcc, the flag -std=gnu17 is supported by all gcc versions since a long time.

I double checked by executing this script in the scalingo-22 container and I confirm it works.

Frzk · 2026-05-27T09:53:55Z

question: this file is not required anymore for scalingo-26, but is it for older stacks?

I restored this file.

Frzk · 2026-05-27T09:54:03Z

question: this file is not required anymore for scalingo-26, but is it for older stacks?

I renamed this file to get_libtidy but it eventually still exists.

Frzk · 2026-05-27T09:55:43Z

 	--with-pdo-sqlite
 	--with-pgsql
 	--with-readline
+	--with-tidy


question: is this option valid for PHP < 8.5? And stacks < scalingo-26?

That's a great question, I hadn't thought about it.

I tried to compile PHP 8.2.31 on scalingo-22 with this with-tidy flag and it seems to work. During the configure step, I can see:

checking for TIDY support... yes checking for tidyOptGetDoc in -ltidy... yes checking for tidyReleaseDate in -ltidy... yes

If I remove this flag, there is:

checking for TIDY support... no

Hence I think it's ok for all PHP versions on all supported stacks. WDYT?

After some internal discussions, I eventually dropped it

Frzk · 2026-05-27T09:59:02Z

@@ -32,9 +32,12 @@ source "../conf/versions.sh"
 #
 skip=( "imap" "amqp" "igbinary" )


Actually, amqp is now supported with PHP 8.5.x (https://doc.scalingo.com/changelog#changelog-buildpacks-php-amqp-ext-2-2-0), so (my bad, actually):

Suggested change

skip=( "imap" "amqp" "igbinary" )

skip=( "imap" "igbinary" )

Frzk · 2026-05-27T09:59:50Z

 php::pkg::download_extract "${zlib_url}" "${tempdir}" "${tempdir}"
 php::pkg::zlib::compile "${tempdir}/zlib-${zlib_version}" "${zlib_dir}"

+echo "-----> Installing libtidy from APT repository"


question: same as above, is this OK/required for stacks < scalingo-26?

This is required for the with-tidy flag to work. It works on scalingo-22 with PHP 8.2.31.

After some internal discussions, I eventually dropped it

Frzk · 2026-05-27T10:00:16Z

praise: thanks for adding the comments 👍

Frzk

praise: thanks for all the hard work, adding comments where necessary, and cleaning things <333

Frzk · 2026-05-29T09:01:06Z

@@ -1,22 +1,25 @@
 #!/bin/bash
+#
+# Compile the Tidy PHP extension (https://www.php.net/manual/en/book.tidy.php). The outcome is a .so file that is uploaded to the object storage. This file is downloaded during the deployment if a customer enables the Tidy extension.


EtienneM · 2026-05-29T09:19:38Z

+
+cd build/cmake
+# The flag `-DCMAKE_POLICY_VERSION_MINIMUM=3.5` is mandatory for the call to CMake to succeed with versions available in scalingo-26 and more recent.
+cmake ../.. -DCMAKE_INSTALL_PREFIX=/app/vendor/libtidy -DTIDY_COMPAT_HEADERS=true -DCMAKE_POLICY_VERSION_MINIMUM=3.5


The flag -DCMAKE_POLICY_VERSION_MINIMUM=3.5 is mandatory starting with scalingo-26, but it works whatever the stack.

It is mandatory or we face the error:

CMake Error at CMakeLists.txt:20 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. Update the VERSION argument <min> value. Or, use the <min>...<max> syntax to tell CMake that the project requires at least <min> but has been updated to work with policies introduced by <max> or earlier. Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

EtienneM self-assigned this May 22, 2026

EtienneM force-pushed the feat/STORY-3771/scalingo-26 branch from e4dc31d to c73ce92 Compare May 26, 2026 06:04

EtienneM commented May 26, 2026

View reviewed changes

Comment thread conf/versions.sh Outdated

Comment thread support/get_tidy Outdated

Comment thread support/ext-internal/tidy

EtienneM force-pushed the feat/STORY-3771/scalingo-26 branch from 84c47c8 to f24773f Compare May 27, 2026 08:37

Frzk reviewed May 27, 2026

View reviewed changes

EtienneM marked this pull request as ready for review May 27, 2026 12:56

EtienneM force-pushed the feat/STORY-3771/scalingo-26 branch 4 times, most recently from 374120c to 2316e58 Compare May 29, 2026 08:12

EtienneM requested a review from a team as a code owner May 29, 2026 08:12

EtienneM requested review from SCedricThomas and removed request for a team May 29, 2026 08:12

EtienneM force-pushed the feat/STORY-3771/scalingo-26 branch 3 times, most recently from 6c83b56 to eb12c53 Compare May 29, 2026 08:44

EtienneM added 13 commits May 29, 2026 10:45

feat(get_libc_client): add support for scalingo-26

a224afb

feat(get_gmp): explicitely specify the C standard to use

1fd7360

feat(package_php): compile with tidy

15f8ff9

test: add scalingo-26

f43dfe4

docs(package_all): more logs and comments

bed6753

feat(versions): update MongoDB extension from 1.21.0 to 2.3.3

d08e3c2

feat(versions): update New Relic from 12.5.0.30 to 12.7.0.36

b890705

feat(versions): downgrade MongoDB extension from 2.3.3 to 2.0.0

6fc5d04

feat(versions): downgrade MongoDB extension from 2.0.0 to 1.21.0

ca7ae8d

feat(mongodb): apply the patch to fix compilation error when needed

69536ea

feat(mongodb): update from 1.21.0 to 1.21.5

0a75f53

fix(tidy): is actualy an internal extension

abf69af

fix(tidy): actually keep downloading libtidy from GitHub

576eab6

EtienneM force-pushed the feat/STORY-3771/scalingo-26 branch from eb12c53 to 576eab6 Compare May 29, 2026 08:45

EtienneM requested a review from Frzk May 29, 2026 08:58

Frzk approved these changes May 29, 2026

View reviewed changes

EtienneM commented May 29, 2026

View reviewed changes

EtienneM merged commit 4ff0b38 into master May 29, 2026
5 checks passed

EtienneM deleted the feat/STORY-3771/scalingo-26 branch May 29, 2026 09:24

		@@ -32,9 +32,12 @@ source "../conf/versions.sh"
		#
		skip=( "imap" "amqp" "igbinary" )

Uh oh!

Conversation

EtienneM commented May 22, 2026

Uh oh!

notion-workspace Bot commented May 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frzk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Frzk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EtienneM May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EtienneM May 29, 2026 •

edited

Loading