Repository navigation
feat: Add new Setup Wizard with permission checks on app launch - #34
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
🤖 CodeAnt AI — Review Status
|
|
Unable to locate .performanceTestingBot config file |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You've hit your review limit for the week, but don't worry you'll get some more next week! Contact us at hello@zenable.io if you want this rate limit to go away |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| val sharedPreferences = context.getSharedPreferences("battery_rock_prefs", Context.MODE_PRIVATE) | ||
| val isSetupComplete = sharedPreferences.getBoolean("setup_complete", false) | ||
|
|
||
| val allGranted = AppPermission.values().all { PermissionManager.checkPermission(context, it) } && BatteryRockStatus.isModuleActive() |
There was a problem hiding this comment.
Suggestion: The startup gate checks every AppPermission, including permissions explicitly marked optional such as USAGE_ACCESS and BLUETOOTH. Users who skip an optional permission will be routed to the setup wizard on every launch instead of reaching the home screen. Filter by isRequired or use the same permission set as the wizard. [api mismatch]
Severity Level: Major ⚠️
- ❌ Users lacking optional access cannot reach the home screen.
- ⚠️ Launch routing conflicts with AppPermission.isRequired semantics.
- ⚠️ Optional monitoring features are treated as mandatory.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/src/main/java/dev/sayanthrock/batteryrock/BatteryScreen.kt
**Line:** 119:119
**Comment:**
*Api Mismatch: The startup gate checks every `AppPermission`, including permissions explicitly marked optional such as `USAGE_ACCESS` and `BLUETOOTH`. Users who skip an optional permission will be routed to the setup wizard on every launch instead of reaching the home screen. Filter by `isRequired` or use the same permission set as the wizard.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| val onFinishSave = { | ||
| sharedPreferences.edit().putBoolean("setup_complete", true).apply() | ||
| onFinish() | ||
| } |
There was a problem hiding this comment.
Suggestion: This callback permanently records setup as complete and navigates to home without verifying the permissions or module state. The current process can therefore enter HomeScreen with requirements missing, while a later launch applies the stricter gate and sends the user back to setup, producing inconsistent navigation behavior. [logic error]
Severity Level: Major ⚠️
- ⚠️ Home can open with required capabilities unavailable.
- ⚠️ Setup completion state disagrees with launch gating.
- ⚠️ Users experience inconsistent first-launch versus later-launch navigation.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/src/main/java/dev/sayanthrock/batteryrock/SetupScreen.kt
**Line:** 130:133
**Comment:**
*Logic Error: This callback permanently records setup as complete and navigates to home without verifying the permissions or module state. The current process can therefore enter `HomeScreen` with requirements missing, while a later launch applies the stricter gate and sends the user back to setup, producing inconsistent navigation behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| val permissions = listOf( | ||
| AppPermission.NOTIFICATIONS, | ||
| AppPermission.USAGE_ACCESS, | ||
| AppPermission.BATTERY_OPTIMIZATION, | ||
| AppPermission.ALARMS_REMINDERS |
There was a problem hiding this comment.
Suggestion: The wizard exposes only four permissions, but the launch gate requires every AppPermission, including FOREGROUND_SERVICE and BLUETOOTH. A user with denied Bluetooth cannot resolve that missing requirement from this wizard, so subsequent launches keep returning to setup despite the completion action. [incomplete implementation]
Severity Level: Major ⚠️
- ❌ Bluetooth-denied users cannot satisfy the startup gate.
- ⚠️ Setup repeatedly reappears after Continue Anyway.
- ⚠️ Required launch checks are not represented by wizard cards.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/src/main/java/dev/sayanthrock/batteryrock/SetupScreen.kt
**Line:** 135:139
**Comment:**
*Incomplete Implementation: The wizard exposes only four permissions, but the launch gate requires every `AppPermission`, including `FOREGROUND_SERVICE` and `BLUETOOTH`. A user with denied Bluetooth cannot resolve that missing requirement from this wizard, so subsequent launches keep returning to setup despite the completion action.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| onClickEnable = { | ||
| // Normally you can't just "enable" Xposed via intent easily, | ||
| // but maybe we can open LSPosed manager if installed. | ||
| } |
There was a problem hiding this comment.
Suggestion: The root/Xposed card displays a Grant Permission button when the module is inactive, but its callback is empty, so tapping the only offered remediation performs no action and cannot change the status. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Inactive-module users receive a nonfunctional remediation control.
- ⚠️ Setup provides no direct path toward enabling LSPosed.
- ⚠️ Users must discover external module-management steps themselves.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** app/src/main/java/dev/sayanthrock/batteryrock/SetupScreen.kt
**Line:** 183:186
**Comment:**
*Incomplete Implementation: The root/Xposed card displays a `Grant Permission` button when the module is inactive, but its callback is empty, so tapping the only offered remediation performs no action and cannot change the status.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
User description
This pull request adds a new initial setup wizard to the app that intercepts normal app launch if essential permissions and root capabilities are not enabled.
Features:
SetupScreen.ktfeaturing a Welcome step and a Permissions step modeled after the user's provided screenshots.BatteryScreen.ktto dynamically route new users to"setup"instead of"home"if the standard set of permissions and root/Xposed capabilities are not active.PR created automatically by Jules for task 4216125469421869305 started by @SayanthRock
CodeAnt-AI Description
Guide first-time users through required permissions before opening Battery Rock
What Changed
Impact
✅ Clearer first-launch guidance✅ Faster access to missing permission settings✅ Fewer configuration-related app failures💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.