feat: add library selection filter - #2
Draft
hikyuu wants to merge 4 commits into
Draft
Conversation
- Introduce library-level filtering for ingest hook via `SelectedLibraryIds` - Add `SkipEmbeddedLanguageCodes` option to skip translation based on embedded subtitle languages - Populate library and language multi-select lists in plugin UI - Extend entry point to only process items in selected libraries - Check embedded subtitle languages against skip list before translating
Add support for Arabic, Korean, Thai, Vietnamese, Indonesian, Turkish, and Malay in both language selector options and ffprobe lookup table.
…vider Extract FfprobeLanguageLookup from SubtitleSourceResolver into LanguageSelectOptionProvider to centralize language code mapping and allow reuse by other components.
hikyuu
marked this pull request as draft
June 3, 2026 16:46
This reverts the embedded language skip filter feature, keeping only the library selection filter. The LanguageSelectOptionProvider and related ShouldSkipEmbeddedByLanguage logic are removed. Reason: The embedded language skip approach (matching embedded subtitle track languages via ffprobe) was deemed not robust enough. The original HasEmbeddedTargetSubtitle check is restored. This partially reverts: - feat(libraries): add library selection and embedded language skip filter - feat(languages): add missing language entries - refactor(languages): move ffprobe language lookup table to shared provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
新增媒体库选择过滤功能,让用户可以精确控制翻译范围。
变更内容
媒体库选择过滤 (Library Selection Filter)
涉及的文件
测试说明