Repository navigation
fix(admin): cover Vibez, streaks, polls and every app account in a full wipe - #311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #296. A full wipe (
/wipemyphone, the admin panel, the gks SIM shim and the QBox character-deleted hook from #300) still left data behind.Changes
Tables keyed by the character, now deleted:
phone_id,phone_medical_id,phone_signatures,phone_garage_images,phone_mail_saved_emails,phone_racing_notifications,phone_service_msg_reads,phone_streaks,phone_streak_posts,phone_streak_likes.Dependent rows
like_counton posts they liked is counted down first, since it is a stored column.Vibez had no block at all. Profiles, posts, comments, comment likes, likes, saves, follows and notifications are now wiped, the same way Photogram is.
Every account, not one per app. The account lookup kept a single username per app, so a character holding two Photogram, Cherry, Ryde or Vibez accounts kept the second one's content while the account row itself was deleted. That left posts and DMs under a username someone else could then register. Each app now loops over every account.
Deliberately left alone:
phone_saved_jobs(the multijob roster),phone_secret_apps(server-awarded unlocks), cloud backups, SIM cards, job invites and fires, service invoices, and the admin and MDT tables.Testing
Live on a QBox dev server with MariaDB. Seeded a throwaway character and a bystander across every table above (two Vibez accounts, a Birdy poll, streak posts each had liked, group invites both ways, a queued message), then fired
qbx_core:server:characterDeletedfor the throwaway:like_count1 to 0.phone_saved_jobsandphone_secret_appswere untouched.Lua suite: 597 passed, with the same two suite errors as
main. A new wipe suite runs the realwipeCidagainst a recording database and pins both what is wiped and what is left alone.Breaking Changes
None.