Repository navigation
fix(notifications): drop phone banners when the player carries no phone - #303
Merged
Github-Samuel merged 1 commit intoOct 6, 2026
Conversation
Incoming messages (and every other app banner) still popped up for a player with no phone item, because the senders push sd-phone:client:notify without checking inventory. Gate the banner at the client entry point instead of at each sender: the handler asks the new sd-phone:server:carriesPhone callback, which reads util.carriesPhone from the live inventory, and drops the banner when it returns false. Emergency alerts still get through, and servers with no Phone.Items configured are unaffected. Message data is still delivered, so the text is there once a phone is picked up again; only the pop-up is suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoming messages (and every other app banner) still popped up for a player with no phone item, because the senders push sd-phone:client:notify without checking inventory.
Gate the banner at the client entry point instead of at each sender: the handler asks the new sd-phone:server:carriesPhone callback, which reads util.carriesPhone from the live inventory, and drops the banner when it returns false. Emergency alerts still get through, and servers with no Phone.Items configured are unaffected.
Message data is still delivered, so the text is there once a phone is picked up again; only the pop-up is suppressed.
Summary
Describe what this PR changes.
Type of Change
Related Issues
Closes #
or
Related to #
Testing
Describe how this was tested.
Breaking Changes
Does this introduce any breaking changes?
If yes, explain.
Checklist