Fix course validation and progress tracking - #13
Merged
Conversation
SamuelSchlesinger
marked this pull request as ready for review
July 23, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dir/nameidentities, reject ambiguous bare names, and migrate legacy progress conservativelyverifyfail when any exercise is incomplete, narrow analysis claims to the proved theorem boundary, and add regression coverage in CIWhy
The analysis course reused several bare exercise names across worlds. Progress keys and lookups used only those names, so one completion could count twice and later exercises could be silently skipped. Several intro validators also checked only part of their stated tasks, and IO exercises were never executed. Finally,
verifyalways exited successfully and the analysis prose overstated the formalized structure.Impact
Existing progress remains compatible and is upgraded in memory on load. Unique bare names still work; repeated names now require the qualified names shown by the CLI. Incorrect intro implementations and silent IO programs are rejected, while automation can rely on
verify's exit status.Validation
lake build(257 jobs)lake env lean --run tests/LeanlingsRegression.leanverifyrun returned exit status 1git diff --check