Skip to content

add debounce to search #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamuZad wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add debounce to search #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b85c21
add debounce to search
SamuZad Jan 14, 2023
a46c98b
Merge branch 'master' into feat/debounce-search
SamuZad Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const notify = new Notify(document.querySelector('#notify'));
var resultList = document.getElementById('resultList');
var searchInput = document.getElementById('vault-search');
var searchRegex, vaultServerAdress, vaultToken, secretList;
let searchKickoff;

async function mainLoaded() {
var tabs = await browser.tabs.query({ active: true, currentWindow: true });
Expand Down Expand Up @@ -95,8 +96,11 @@ async function querySecrets(searchString, manualSearch) {
}

const searchHandler = function (e) {
clearTimeout(searchKickoff);
if (e.key === 'Enter') {
mainLoaded()
} else {
searchKickoff = setTimeout(() => mainLoaded(), 1000);

@Gerard-CK Gerard-CK Jan 15, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that'll give the user two options. Maybe worth experimenting a bit with the timer and see where's the sweet spot. I would perhaps try sub 1s (something in the 700-900 range)

}
};

Expand Down